dash: destroy items's child before tooltip

Destroy the DashItemContainer's child from the same handler as the tooltip. This
will prevent invalid reads when the item is destroyed while its quicklist is
still open.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/781

diff --git a/js/ui/dash.js b/js/ui/dash.js
index 60d0309412eec7ec4459d3f5b287472aa37433e3..ce970a6100c490b36c64e1799233ec326813c4da 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -55,6 +55,8 @@ var DashItemContainer = new Lang.Class({
         this.animatingOut = false;
 
         this.connect('destroy', () => {
+            if (this.child != null)
+                this.child.destroy();
             this.label.destroy();
         });
     },